Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

Request body 'token' parameter disappears #420

Closed
maksnester opened this issue Feb 13, 2017 · 2 comments
Closed

Request body 'token' parameter disappears #420

maksnester opened this issue Feb 13, 2017 · 2 comments

Comments

@maksnester
Copy link

Using feathers-authentication 0.7.12.
In feathers-authentication\lib\middleware\express.js I found this code:

    // Check the body next if we still don't have a token
    if (req.body.token) {
      token = req.body.token;
      delete req.body.token;
    }

And same for req.params. I wanted to ask why you are removing the token from everywhere? I tried to use a token field in POST body for my custom middleware, and I was confused a bit when all the time the token disappeared on server-side . Is there some security reason or ... ?

@daffl
Copy link
Member

daffl commented Feb 25, 2017

This was a bug in v0.x. If this is an issue I'd recommend trying to upgrade to v1.0.

@maksnester
Copy link
Author

Alright then, let's close it.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants