Authentication not worked with hooks.remove('password')

[kulakowka]

When I try to login POST http://localhost:3030/auth/local, I get an error:

{
  "name": "GeneralError",
  "message": "data and hash arguments required",
  "code": 500,
  "className": "general-error",
  "data": {},
  "errors": {}
}

In this situation, I have one hook for users service:

exports.after = {
  all: [],
  find: [
    hooks.remove('password')
  ],
  get: [],
  create: [],
  update: [],
  patch: [],
  remove: []
}

When i remove

hooks.remove('password')

from after find hook, authentication is worked!

This is because the auth service uses method .find() in users service.

[ekryski]

@kulakowka yes it's because of this issue feathersjs-ecosystem/feathers-hooks#48

There's a PR open for it: feathersjs-ecosystem/feathers-hooks#51. Will be merge shortly 😄

[ekryski]

feathers-hooks@1.2.0 now fixes this. As an example, say we want to only remove the password if it is an external call (ie. over sockets or http(s)):

exports.after = {
  all: [hooks.remove('password', hook => hook.params.provider)]
};

[ekryski]

We're going to make one more change so that you don't even need to do that.

[kulakowka]

@ekryski it's cool! 🍺🍺