This repository was archived by the owner on Mar 22, 2022. It is now read-only.
jwt ssl warning #214
Merged
jwt ssl warning #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ const defaults = { | |||
| cookie: { | |||
| name: 'feathers-jwt', | |||
| httpOnly: false, | |||
| secure: process.env.NODE_ENV === 'production' ? true : false | |||
| secure: process.env.NODE_ENV === 'production' | |||
|
@aboutlo this is awesome! Nice work! I think we do need |
aboutlo
force-pushed
the
ls-JWT-ssl-warning
branch
from
fc3c054 to
7ed2fda
Compare
|
Thank you @ekryski for the kind words. I added back |
|
Oh sorry, this was totally good to go to. I'll merge it in, it'll make it into the next release. |
|
Yup |
|
cool |
|
Released v0.7.9 with this fix in! 🍻 @aboutlo! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look https://github.com/feathersjs/feathers-authentication/compare/master...aboutlo:ls-JWT-ssl-warning?diff=unified&expand=1&name=ls-JWT-ssl-warning#diff-1fdf421c05c1140f6d71444ea2b27638L60
In my opinion
app.get('auth')is always undefined at this stage.