fix: Fix AdapterService multi option when set to true (#1134)

feathersjs · Dec 17, 2018 · 40402fc · 40402fc
1 parent a6615d4
commit 40402fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/adapter-commons/lib/service.js b/packages/adapter-commons/lib/service.js
@@ -11,7 +11,7 @@ const callMethod = (self, name, ...args) => {
 
 const checkMulti = (method, option) => {
   if (option === true) {
-    return;
+    return true;
   }
 
   return Array.isArray(option) ? option.includes(method) : false;

diff --git a/packages/adapter-commons/test/service.test.js b/packages/adapter-commons/test/service.test.js
@@ -98,6 +98,15 @@ describe('@feathersjs/adapter-commons/service', () => {
           assert.strictEqual(error.message, 'Can not create multiple entries');
         });
     });
+
+    it('multi can be set to true', () => {
+      const service = new MethodService();
+
+      service.options.multi = true;
+
+      return service.create([])
+        .then(() => assert.ok(true));
+    });
   });
 
   it('filterQuery', () => {