fix: Check query for NaN (#1607)

feathersjs · Oct 7, 2019 · f1a781f · f1a781f
1 parent 4bbc0d7
commit f1a781f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/adapter-commons/src/filter-query.ts b/packages/adapter-commons/src/filter-query.ts
@@ -13,7 +13,7 @@ function parse (number: any) {
 // default and max pagination settings
 function getLimit (limit: any, paginate: any) {
   if (paginate && paginate.default) {
-    const lower = typeof limit === 'number' ? limit : paginate.default;
+    const lower = typeof limit === 'number' && !isNaN(limit) ? limit : paginate.default;
     const upper = typeof paginate.max === 'number' ? paginate.max : Number.MAX_VALUE;
 
     return Math.min(lower, upper);

diff --git a/packages/adapter-commons/test/filter-query.test.ts b/packages/adapter-commons/test/filter-query.test.ts
@@ -107,6 +107,12 @@ describe('@feathersjs/adapter-commons/filterQuery', () => {
         assert.strictEqual(filters.$limit, 10);
         assert.strictEqual(filtersNeg.$limit, 10);
       });
+
+      it('limits with default pagination when not a number', () => {
+        const { filters } = filterQuery({ $limit: 'something' }, { paginate: { default: 5, max: 10 } });
+
+        assert.strictEqual(filters.$limit, 5);
+      });
     });
   });