Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move adapter tests into their own module #1164

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Move adapter tests into their own module #1164

merged 2 commits into from
Jan 10, 2019

Conversation

daffl
Copy link
Member

@daffl daffl commented Jan 10, 2019

It turned out to not be a great idea to have tests and utilities in the same repository. Since new modules are easy to add, the tests will be moved into their own module at @feathersjs/adapter-tests.

This also adds an additional test that makes sure a query with the id property of the service will throw an error. So something like:

app.service('messages').remove(1, { query: { id: 2 } });

Should fail if id is the id property because the id in the request and the query is not the same. This is important to e.g. secure a /users service easily by adding a query.

@daffl daffl merged commit dcc1e6b into master Jan 10, 2019
@daffl daffl deleted the adapter-tests branch January 10, 2019 02:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant