Move adapter tests into their own module #1164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out to not be a great idea to have tests and utilities in the same repository. Since new modules are easy to add, the tests will be moved into their own module at
@feathersjs/adapter-tests
.This also adds an additional test that makes sure a query with the
id
property of the service will throw an error. So something like:Should fail if
id
is the id property because the id in the request and the query is not the same. This is important to e.g. secure a/users
service easily by adding a query.