Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(authentication-client): Reset authentication promise on socket disconnect #1696

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

daffl
Copy link
Member

@daffl daffl commented Nov 20, 2019

This PR updates the authentication client to defer authentication as soon as a socket disconnects instead of only on socket reconnect because calls made while disconnected will still get a NotAuthenticated errors.

@marshallswain
Copy link
Member

Not sure what Code Climate's deal is, but everything else look like :shipit:

@KidkArolis
Copy link
Contributor

Tested in my app and it works great, much simpler than what I was doing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants