fix(cli): Fix MongoDB connection database name parsing #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the feathers discord: The current parsing method fails the following MongoDB connection string: ``` mongodb://user:P%40ss@localhost:27017/databaseName?authSource=admin ``` Where it parses `databaseName?authSource=admin` as the database name instead of just `databaseName`. The following change should parse all database connection strings correctly.
👷 Deploy request for feathers-dove pending review.Visit the deploys page to approve it
|
daffl
changed the title
|
Great, thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the feathers discord:
The current parsing method fails the following MongoDB connection string:
Where it parses
databaseName?authSource=adminas the database name instead of justdatabaseName.The following change should parse all database connection strings correctly.
There don't seem to be any open issues related to this, and it isn't dependent on PRs in other repos.