Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(schema): Allow query schemas with no properties, error on unsupported types #2904

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented Dec 3, 2022

This pull request fixes an issue in the querySyntax helpers for JSON schema and TypeBox where it threw an error when passing an empty schema (no properties) which should still be possible. It now also throws a more descriptive error when trying to create a query syntax helper for a non-primitive type which is currently not possible.

@netlify
Copy link

netlify bot commented Dec 3, 2022

Deploy Preview for feathers-dove canceled.

Name Link
🔨 Latest commit 45c59a4
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/638b86286551da0008196d1b

@daffl daffl changed the title fix(schema): Allow query schemas with no properties and properly error on unsupported property types fix(schema): Allow query schemas with no properties, error on unsupported types Dec 3, 2022
@daffl daffl requested a review from marshallswain December 3, 2022 19:55
@daffl daffl merged commit b66c734 into dove Dec 6, 2022
@daffl daffl deleted the query-schema branch December 6, 2022 00:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants