Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(mongodb): Add Object ID keyword converter and update MongoDB CLI & docs #3041

Merged
merged 8 commits into from
Feb 9, 2023

Conversation

marshallswain
Copy link
Member

@marshallswain marshallswain commented Feb 5, 2023

Fixes two issues:

  • Make CLI install correct versions of database-client packages (like mongodb client v5)
  • Adds the objectid keyword as an export from the mongodb package. So now we can use it in our schemas to automatically convert ObjectIds with AJV:
Type.String({ objectid: true })

@marshallswain marshallswain marked this pull request as draft February 5, 2023 06:24
@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for feathers-dove ready!

Name Link
🔨 Latest commit 742eafc
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63e41b1c0aa3ac000822c8f8
😎 Deploy Preview https://deploy-preview-3041--feathers-dove.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marshallswain marshallswain changed the title WIP: MongoDB CLI & docs changes MongoDB CLI & docs changes Feb 8, 2023
@daffl daffl changed the title MongoDB CLI & docs changes feat(mongodb): Add Object ID keyword converter and update MongoDB CLI & docs Feb 8, 2023
@daffl daffl marked this pull request as ready for review February 8, 2023 20:06
@marshallswain marshallswain requested a review from daffl February 8, 2023 21:53
@marshallswain
Copy link
Member Author

:shipit: It's my PR, so you'll have to review and approve. I've reviewed everything you added. Looks good.

@daffl daffl merged commit ca0994e into dove Feb 9, 2023
@daffl daffl deleted the mongodb-changes branch February 9, 2023 01:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants