Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(authentication-client): removeAccessToken throws error if storage not defined #3195

Merged
merged 2 commits into from
Jun 7, 2023
Merged

fix(authentication-client): removeAccessToken throws error if storage not defined #3195

merged 2 commits into from
Jun 7, 2023

Conversation

foxhound87
Copy link
Contributor

fix: removeAccessToken throws error if storage not defined

marshallswain
marshallswain reviewed May 21, 2023
View reviewed changes
Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the problem and making the effort to open a PR. I think if we move the check for storage into removeAccessToken it might help us avoid this same scenario if removeAccessToken is ever called for a different reason/angle.

packages/authentication-client/src/core.ts Outdated Show resolved Hide resolved
@daffl daffl changed the title fix: removeAccessToken throws error if storage not defined on handleE… fix(authentication-client): removeAccessToken throws error if storage not defined Jun 7, 2023
@daffl daffl merged commit b8e2769 into feathersjs:dove Jun 7, 2023
@daffl
Copy link
Member

daffl commented Jun 7, 2023

This is a good catch, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marshallswain marshallswain marshallswain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foxhound87 @daffl @marshallswain