Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Typescript definition bug #63

Closed
superbarne opened this issue Mar 1, 2017 · 3 comments
Closed

Typescript definition bug #63

superbarne opened this issue Mar 1, 2017 · 3 comments

Comments

@superbarne
Copy link
Contributor

Steps to reproduce

it should be:
declare function socketio(connections:any, options?:any):Function;
right?
https://github.com/feathersjs/feathers-socketio/blob/master/client.d.ts#L3

Expected behavior

Because it returns a Function:
https://github.com/superbarne/feathers-socketio/blob/master/src/client.js#L18
@daffl
Copy link
Member

daffl commented Mar 1, 2017

Sounds about right. If you submit a PR with the fix we can get a patch out right away.

@superbarne superbarne mentioned this issue Mar 1, 2017
Merged
@superbarne
Copy link
Contributor Author

@daffl done

daffl pushed a commit that referenced this issue Mar 2, 2017
@superbarne @daffl
fix Typescript issue (#63) (#64)
a6f2350
@daffl
Copy link
Member

daffl commented Mar 2, 2017

Closed via #64

@daffl daffl closed this as completed Mar 2, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @superbarne