This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Add port argument #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great, thank you! Could you create another PR that adds the appropriate documentation below https://docs.feathersjs.com/api/socketio.html#appconfiguresocketiooptions--callback ? Then we can merge and release. |
kostia-official
added a commit
to kostia-official/feathers-docs
that referenced
this pull request
Apr 17, 2017
|
@daffl Okay, I've added information about the port argument. |
daffl
pushed a commit
to feathersjs-ecosystem/docs
that referenced
this pull request
Apr 18, 2017
|
Awesome, thank you! Released as v1.6.0 and documentation has been published as well. |
|
Nice @kozzztya! Thanks for all the great PRs! 😄 |
|
You're welcome. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added port argument according to these discussions #66
Please check.
Closes feathersjs-ecosystem/docs#461