From e9a6ebfa834885e089847495a84ccfa87d3b1ecb Mon Sep 17 00:00:00 2001 From: Woomy Date: Thu, 2 Feb 2023 19:53:54 +0100 Subject: [PATCH] ci/release: Cleanup release workflow * Use common variable for node version * Directly write changelog.txt from action (drop genlog.sh) Signed-off-by: Woomymy --- .github/bin/genlog.sh | 4 ---- .github/workflows/release.yml | 10 +++++----- 2 files changed, 5 insertions(+), 9 deletions(-) delete mode 100644 .github/bin/genlog.sh diff --git a/.github/bin/genlog.sh b/.github/bin/genlog.sh deleted file mode 100644 index 7809571..0000000 --- a/.github/bin/genlog.sh +++ /dev/null @@ -1,4 +0,0 @@ -#!/usr/bin/env bash -DIRNAME="$(dirname $0)" - -$DIRNAME/changelog.sh > "${GITHUB_WORKSPACE}/changelog.txt" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a53f8a5..bf143e2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -8,6 +8,7 @@ on: env: REGISTRY: ghcr.io IMAGE_NAME: ${{ github.repository }} + NODE_VERSION: 18 jobs: lint: @@ -18,7 +19,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: '18' + node-version: ${{ env.NODE_VERSION }} - name: Install dependencies run: npm install - name: Lint @@ -31,7 +32,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: '18' + node-version: ${{ env.NODE_VERSION }} - name: Install dependencies run: npm install - name: Build @@ -46,13 +47,12 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: '18' + node-version: ${{ env.NODE_VERSION }} - name: Install dependencies run: npm install - name: Gen changelog - run: bash .github/bin/genlog.sh + run: bash .github/bin/changelog.sh > ${GITHUB_WORKSPACE}/changelog.txt - name: Create release - id: create_release uses: softprops/action-gh-release@v1 with: body_path: '${{ github.workspace }}/changelog.txt'