Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[web] Update links to Koji builds should not use koji search #5536

Open
juhp opened this issue Nov 21, 2023 · 1 comment
Open

[web] Update links to Koji builds should not use koji search #5536

juhp opened this issue Nov 21, 2023 · 1 comment
Labels
medium-gain medium-trouble WebUI Issues pertaining to Bodhi's web interface

Comments

@juhp
Copy link

juhp commented Nov 21, 2023

It should be possible for Bodhi to know the exact koji build corresponding to an NVR (since they must be unique).

eg https://bodhi.fedoraproject.org/updates/FEDORA-2023-1be0af64c4 has a build link:
https://koji.fedoraproject.org/koji/search?terms=distrobox-1.6.0.1-1.fc39&type=build&match=exact
which should be simplified to just https://koji.fedoraproject.org/koji/buildinfo?buildID=2322876
(it is just a simple Koji API call to get the buildid corresponding to an NVR).

Opening the direct link is noticeably faster for me: in fact I deliberately don't open Bodhi build links because of this...

@mattiaverga mattiaverga added WebUI Issues pertaining to Bodhi's web interface medium-trouble medium-gain labels Nov 24, 2023
@mattiaverga mattiaverga added this to the 8.0 milestone Nov 24, 2023
@mattiaverga mattiaverga removed this from the 8.0 milestone Dec 3, 2023
@mattiaverga
Copy link
Contributor

This is rather tricky: we have Build.get_build_id(), but it needs to query Koji, thus may slow down page generation.
I'm postponing after 8.0 release to look into that. Maybe we can just store the build id in database, if it is handy for other tasks too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
medium-gain medium-trouble WebUI Issues pertaining to Bodhi's web interface
Projects
None yet
Development

No branches or pull requests

2 participants