-
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
Hey @sublinus - thanks for the submission! When testing the PR I was trying to execute the test like I am used to from the root directory. That caused the problem that the What's your opinion on this? That's what happens to me when executing it from the root directory:
|
Thanks a lot for the feedback @femueller. Further I also added a new build target in the Makefile, which uses the "pipenv run" command to make sure the pytest from the project virtual environment is used. |
Great! Thanks for addressing it so quickly! I will merge your contribution and for future submissions, I would suggest creating a new PR. |
Writing unit tests for config and api as in #3
I am submitting a work in progress. For now only the config tests are written.
I would really appreciate some feedback on the tests so far.