This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Fix handling of SMS OTP whose first digit is 0 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusressel
suggested changes
Aug 8, 2020
n26/api.py
Outdated
| @@ -452,7 +452,7 @@ def _complete_authentication_flow(self, mfa_token: str) -> dict: | |||
| mfa_response_data['grant_type'] = "mfa_otp" | |||
|
|
|||
| hint = click.style("Enter the 6 digit SMS OTP code", fg="yellow") | |||
| mfa_response_data['otp'] = click.prompt(hint, type=int) | |||
| mfa_response_data['otp'] = click.prompt(hint) | |||
There was a problem hiding this comment.
I'd prefer an explicit type=str with a comment above that explains it. This way we will know why this is important lateron.
The cast to int was removing that digit, but it's meaningful. Without this change, it just keeps requesting the same OTP without sending a new one, and never accepting the user input.
dequis
force-pushed
the
sms-otp-starting-with-zero
branch
from
f853dce to
1b1024b
Compare
|
Thank you! ❤️ |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast to int was removing that digit, but it's meaningful.
Without this change, it just keeps requesting the same OTP without sending a new one, and never accepting the user input.
That was originally added in #70 (the original PR that added SMS MFA support) as part of a code review that requested changing
input()to use click. There was no requirement to use a type, and the original version worked just fine withinput()returning a string.