Skip to content
This repository has been archived by the owner on Oct 29, 2023. It is now read-only.

Bank transfer order functionality added #90

Merged
merged 6 commits into from
Oct 14, 2020

Conversation

aynetdia
Copy link
Contributor

@aynetdia aynetdia commented Oct 6, 2020

These changes allow to create bank transfer orders in the CLI. I followed the N26 documentation when implementing them: https://docs.n26.com/cs/N26-PSD2-FallbackAPI-PISP-access-documentation.pdf

This is my first pull request ever, so I apologise for any possible mistakes.

Copy link
Collaborator

@markusressel markusressel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I was not aware of the document you linked to.
This PR looks very clean and concise already, let's discuss the remaining points and get this live! 🤓

@markusressel
Copy link
Collaborator

Just to be sure:
I assume you did test this already and can confirm that it works?

@aynetdia
Copy link
Contributor Author

aynetdia commented Oct 9, 2020

And yes, I of course tested this new functionality and can confirm that it works.

@markusressel
Copy link
Collaborator

I did some final adjustments and will merge now.
Thx a lot! 🥳

@markusressel markusressel merged commit 8d2bed2 into femueller:master Oct 14, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants