This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Bank transfer order functionality added #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusressel
suggested changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, I was not aware of the document you linked to.
This PR looks very clean and concise already, let's discuss the remaining points and get this live! 🤓
Just to be sure: |
And yes, I of course tested this new functionality and can confirm that it works. |
markusressel
suggested changes
Oct 9, 2020
I did some final adjustments and will merge now. |
markusressel
approved these changes
Oct 14, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow to create bank transfer orders in the CLI. I followed the N26 documentation when implementing them: https://docs.n26.com/cs/N26-PSD2-FallbackAPI-PISP-access-documentation.pdf
This is my first pull request ever, so I apologise for any possible mistakes.