Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

templates: Remove wit-bindgen-backport dependency #1581

Closed
lann opened this issue Jun 13, 2023 · 1 comment · Fixed by #1822
Closed

templates: Remove wit-bindgen-backport dependency #1581

lann opened this issue Jun 13, 2023 · 1 comment · Fixed by #1822
Labels
area/app-def-and-config Application definition and manifest Consider-for-2.0

Comments

@lann
Copy link
Collaborator

lann commented Jun 13, 2023

This is the last vestage of "old" wit-bindgen in spin; app usage of the old ABI is now handled by the spin-componentize adaptation.

After some discussion, I think one of the following should be done:

  • Remove the custom filters feature; the only known usage of it is this simple filter which could be moved into a regular filter impl in spin-templates.

  • Commit the wit-bindgen-generated source for the custom-filter.wit rather than using the wit-bindgen macro. Breaking changes in the wasmtime APIs that this generated code uses should be rare but would require manual fixes to that code. Guest code would be stuck with old wit-bindgen versions, but that isn't necessarily a major problem for this use.

  • Convert custom filters to use the component model. I think as long as the custom filter "world" doesn't include WASI this might be fine.

@kate-goldenring kate-goldenring moved this to 🆕 Triage Needed in Spin Triage Jun 15, 2023
@kate-goldenring kate-goldenring added the area/app-def-and-config Application definition and manifest label Jun 15, 2023
@kate-goldenring kate-goldenring moved this from 🆕 Triage Needed to 📋 Investigating / Open for Comment in Spin Triage Jun 15, 2023
@melissaklein24 melissaklein24 moved this to 🆕 New in Spin 2.0 Sep 21, 2023
@melissaklein24 melissaklein24 moved this from 🆕 New to Must Haves in Spin 2.0 Sep 27, 2023
@lann
Copy link
Collaborator Author

lann commented Sep 27, 2023

I think we've settled on the breaking change of removing the functionality for 2.0.

@github-project-automation github-project-automation bot moved this from 📋 Investigating / Open for Comment to ✅ Done in Spin Triage Oct 3, 2023
@itowlson itowlson moved this from Must Haves to ✅ Done in Spin 2.0 Oct 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/app-def-and-config Application definition and manifest Consider-for-2.0
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants