Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Content-ID header when needed #154

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

arnaudmorisset
Copy link
Contributor

This pull request add a header Content-ID to email when given Bamboo.attachment have a content_id set.

@kdisneur
Copy link
Contributor

kdisneur commented Nov 9, 2020

Task linked: CU-9ux43d Handle PR #113: Adding cid

@arnaudmorisset arnaudmorisset force-pushed the CU-9ux43d_support-content-id branch from 0dc9242 to 97e1dbd Compare November 10, 2020 08:04
@arnaudmorisset arnaudmorisset merged commit 644740d into develop Nov 10, 2020
@arnaudmorisset arnaudmorisset deleted the CU-9ux43d_support-content-id branch November 10, 2020 14:34
This was referenced Nov 23, 2020
MatheusBueno782 added a commit that referenced this pull request Nov 24, 2020
Bump to v3.1.0

This release contains:

Fix for using custom config with response: true by bumping bamboo version to ~> 1.6 (#150)
Implement our custom test adapter ([#151])
Fix CI random failure by attaching FakeGenSMTP Server process to Test supervision tree.(#153)
Add Content-ID header when needed(#154)
Base 64 encode the headers only when the content contains non-ASCII characters.(#155)
Handle :permanent_failure exception and re-raising it as a SMTPError.(#156)
After bumping the dependencies, the project requires(#149):
credo ~> 1.4.1
bamboo ~> 1.6
excoveralls ~> 0.13.3
gen_smtp ~> 1.0.1
MatheusBueno782 added a commit that referenced this pull request Nov 24, 2020
Bump to v3.1.0

This release contains:

Fix for using custom config with response: true by bumping bamboo version to ~> 1.6 (#150)
Implement our custom test adapter ([#151])
Fix CI random failure by attaching FakeGenSMTP Server process to Test supervision tree.(#153)
Add Content-ID header when needed(#154)
Base 64 encode the headers only when the content contains non-ASCII characters.(#155)
Handle :permanent_failure exception and re-raising it as a SMTPError.(#156)
After bumping the dependencies, the project requires(#149):
credo ~> 1.4.1
bamboo ~> 1.6
excoveralls ~> 0.13.3
gen_smtp ~> 1.0.1
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants