Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing gem dependency on rexml #109

Closed
mostlyobvious opened this issue Sep 8, 2021 · 2 comments
Closed

Missing gem dependency on rexml #109

mostlyobvious opened this issue Sep 8, 2021 · 2 comments

Comments

@mostlyobvious
Copy link

I've noticed that rexml is a required gem:

letter_opener_web/lib/letter_opener_web.rb

Line 4 in 968d1a0

require 'rexml/document'

Yet it is not mentioned as a runtime dependency in gemspec:

letter_opener_web/letter_opener_web.gemspec

Lines 23 to 25 in 968d1a0

gem.add_dependency 'actionmailer', '>= 3.2'
gem.add_dependency 'letter_opener', '~> 1.0'
gem.add_dependency 'railties', '>= 3.2'

Is it intentional?

If not, perhaps it went unnoticed because development dependencies bring it to the load path.
@mostlyobvious
Copy link
Author

Sorry, just noticed #106

@fgrehm
Copy link
Owner

fgrehm commented Oct 20, 2021

Hey @pawelpacana! yeah, #106 is going in with #113

@fgrehm fgrehm closed this as completed Oct 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fgrehm @mostlyobvious