-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Disable Wave effect when you scroll (touch) #89
Comments
This would be quite difficult to fix, because Waves has to bind touch events. If we had to wait to check whether the user has touched or scrolled, the effect isn't quite as clean. The effect fires before the scroll, so disabling it while the user is scrolling has no impact. In all honesty, it doesn't look overly bad nor impact an application's function. We could try to use fastclick and only fire waves on touch-up events if the user hasn't moved the touch more than x number of pixels, but this means that waves can't appear during touch-and-hold events. I think this depends on which compromise we prefer, and the touch-and-hold is potentially a more important scenario (showing the user is pressing an element), and rippling during touch-scrolling isn't a bad scenario (showing the user has touched/skimmed over an element). Personally, I think this is a |
I will try to find a way how to fix this. |
cool, thanks! |
This is actually quite confusing for a user when you are scrolling a list. Native user experience does not do this. |
@hoxxep has fix this issue. It solved on Windows Phone (IE), could someone check it on other phones like iOS and Android? Here is the preview: http://fian.my.id/Waves/v0.7.0-dev/ |
Works for me on iOS 8. Also: apologies for being so stubbornly against the time delay on waves. I realise I was wrong and it still works well with the delay. |
Works on Android 4.1.2 browser Chrome v 41.0.2272.96 |
Works on Android 4.4 - Chrome v 41.0.2272.96 |
I think it's enough. This will fixes will be bundled in v0.7.0 (currently in dev stage). |
Good job! |
Fairplay, thanks! |
When you scroll down/up, the effect is call everytime you "click -> scroll" over the element. It is possible to disable the effect onScroll?
http://screencast-o-matic.com/u/VAds/waves
The text was updated successfully, but these errors were encountered: