Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add implement markdown file preview in Ace editor #3431

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

ultwcz
Copy link
Contributor

@ultwcz ultwcz commented Aug 28, 2024

I like Filebrowser very much. I also deploy it on my server and use it almost every day. I often use Markdown files,

Reference the following link:
add mavon-editor for markdown file #1127

so I added a Markdown format preview function to it. Use marked to add Markdown support in Ace editor.

I am a novice in Go and JS. I hope you can give me some modification suggestions to verify whether my understanding is correct. Thank you very much.

@ultwcz ultwcz requested a review from o1egl as a code owner August 28, 2024 12:59
@o1egl o1egl merged commit b0f4604 into filebrowser:master Aug 29, 2024
8 checks passed
@ultwcz
Copy link
Contributor Author

ultwcz commented Aug 30, 2024

@o1egl

Thank you for your review. I found some things I did not do well. I will pay special attention to them.

Thank you.

@baur
Copy link

baur commented Sep 5, 2024

@ultwcz

Hi, can you look this issue: #3461

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants