Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LOTUS_FVM_CONCURRENCY=48 causes chain sync panic on migration #10710

Closed
4 of 11 tasks
RobQuistNL opened this issue Apr 20, 2023 · 3 comments
Closed
4 of 11 tasks

LOTUS_FVM_CONCURRENCY=48 causes chain sync panic on migration #10710

RobQuistNL opened this issue Apr 20, 2023 · 3 comments
Labels
area/chain Area: Chain area/fvm kind/enhancement Kind: Enhancement need/team-input Hint: Needs Team Input P3 P3: Might get resolved

Comments

@RobQuistNL
Copy link
Contributor

RobQuistNL commented Apr 20, 2023

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

1.23.0-rc1

Repro Steps

  1. Run lotus daemon with LOTUS_FVM_CONCURRENCY=48 (the max as per the docs)
  2. See chain won't sync after nv19

Describe the Bug

Setting it to LOTUS_FVM_CONCURRENCY=24 fixed the issue.

Potential fix

Maybe cap the value set in the config, if it causes sync issues like these. Or at least show a warning / make the daemon refuse to start.

@RobQuistNL
Copy link
Contributor Author

It looks like this has since been updated in the release notes, so thats good :)

@TippyFlitsUK TippyFlitsUK added P3 P3: Might get resolved kind/enhancement Kind: Enhancement need/team-input Hint: Needs Team Input area/chain Area: Chain area/fvm and removed need/triage kind/bug Kind: Bug labels Apr 27, 2023
@rjan90
Copy link
Contributor

rjan90 commented May 2, 2023

Added a PR for the lotus-docs as well: filecoin-project/lotus-docs#560. Although this value (24) seems to be low enough for most systems, the actual right value depends on the architecture.

The longer term fix would be to consider both the system and whether or not we're going over an upgrade

@Stebalien
Copy link
Member

This should be fixed now (for all versions of the FVM) as we now over-subscribe instead of allocating all instances up-front.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/chain Area: Chain area/fvm kind/enhancement Kind: Enhancement need/team-input Hint: Needs Team Input P3 P3: Might get resolved
Projects
None yet
Development

No branches or pull requests

4 participants