Lotus: fix eth address to f4 conversions

[Stebalien]

We have several places where we're directly constructing a "delegated" address from an eth address where we should be calling api.EthAddress(...).ToFilecoinAddress() (to correctly handle ID addresses).

[ychiaoli18]

@Stebalien after checking all the occurrences of address.NewDelegatedAddress, it seems that they all appear after hashing the pubkey to get the Ethereum address (with one exception in cli/chain.go), so the Ethereum address will not start with a [12]byte{0xff}. Therefore I don't think changing address.NewDelegatedAddress to ethtypes.EthAddress().ToFilecoinAddress() will solve any issue. Could you elaborate more about what you want to achieve?

[Stebalien]

I filed this because I fixed a few cases long ago but didn't do an audit. If you've done a more thorough audit, we can consider this done.

Thanks!

[ychiaoli18]

@Stebalien I still pushed a PR that changed all the NewDelegatedAddress to ToFilecoinAddress(). It doesn't make much difference in functionality but creates f4 addresses more consistently. Do you think this should be merged?

[Stebalien]

I think it makes sense anyways just for consistency. Otherwise, someone is likely to copy code and get it wrong.

[raulk]

Merged in filecoin-project/lotus#9970.