Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix TODO::FVM comments in Lotus #1446

Closed
5 tasks
raulk opened this issue Jan 13, 2023 · 2 comments
Closed
5 tasks

Fix TODO::FVM comments in Lotus #1446

raulk opened this issue Jan 13, 2023 · 2 comments
Milestone
M2.1 (r12) Carbon...

Comments

@raulk
Copy link
Member

raulk commented Jan 13, 2023 •
edited by maciejwitowski
Loading

  • Empty object assertion in invoker.go
  • Null rounds shouldn't ever be represented as tipsets with no blocks URL
  • The contract installation and invocation can be lifted into utility methods URL
  • We can either skip the assertion if the msg has already landed, or pause mining between the embryo creation and this assertion URL
  • The right time to exit this loop isn't after 20 iterations, but when StateWaitMsg returns URL
@raulk raulk added this to the M2.1 (r12) Carbonado.3 milestone Jan 13, 2023
@raulk raulk mentioned this issue Jan 13, 2023
Merged
7 tasks
@maciejwitowski
Copy link
Contributor

Will split them into separate issues.

@maciejwitowski
Copy link
Contributor

Closing after splitting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M2.1 (r12) Carbonado.3
Development

No branches or pull requests
2 participants
@raulk @maciejwitowski