benchy
: The default value of --api-version
does not work properly
#1589
Labels
good first issue
Good for newcomers
Description
Running
benchy
in debug mode and without the--api-version
argument will panic.error:
.required(true)
and.default_value("some value")
are conflicting inclap
, if required is set to true, default value will not work properly.https://github.com/clap-rs/clap/blob/406bfbd3dc472baf402f1f16cd58b5bc7d11fac4/src/build/debug_asserts.rs#L613-#L619
Where to begin
Remove
.required(true)
.rust-fil-proofs/fil-proofs-tooling/src/bin/benchy/main.rs
Lines 85 to 90 in 075a545
rust-fil-proofs/fil-proofs-tooling/src/bin/benchy/main.rs
Lines 109 to 114 in 075a545
rust-fil-proofs/fil-proofs-tooling/src/bin/benchy/main.rs
Lines 133 to 138 in 075a545
rust-fil-proofs/fil-proofs-tooling/src/bin/update_tree_r_cache/main.rs
Lines 319 to 324 in 075a545
rust-fil-proofs/fil-proofs-tooling/src/bin/update_tree_r_cache/main.rs
Lines 344 to 349 in 075a545
rust-fil-proofs/fil-proofs-tooling/src/bin/update_tree_r_cache/main.rs
Lines 369 to 374 in 075a545
Can i fix it? thanks.
The text was updated successfully, but these errors were encountered: