Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[venus-messager] clarify messager state(replace) / 换一个更贴切的Replace状态名称，避免歧义。 #5612

Closed
1 of 11 tasks
Tracked by #5625
hunjixin opened this issue Dec 23, 2022 · 2 comments · Fixed by #5637 or ipfs-force-community/sophon-messager#304
Closed
1 of 11 tasks
Tracked by #5625

[venus-messager] clarify messager state(replace) / 换一个更贴切的Replace状态名称，避免歧义。 #5612

hunjixin opened this issue Dec 23, 2022 · 2 comments · Fixed by #5637 or ipfs-force-community/sophon-messager#304
Assignees
@hunjixin
Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon V-venus-messager venus-messager component
Milestone
Chain Service v1....

Comments

@hunjixin
Copy link
Contributor

链服务模块 / Chain Service Components

  • venus
  • venus-auth
  • venus-gateway
  • venus-messager
  • venus-miner
  • 文档 / docs

订单服务模块 / Deal Service Components

  • venus-market
  • 文档 / docs

算力服务模块 / Storage Power Service Components

  • venus-sector-manager
  • venus-worker
  • 文档 / docs

描述 / Description

venus-messager中消息状态Replace代表的是发现系统外的消息具有相同的from和nonce但是消息cid不相同， 这会导致本条消息无法正常上链，目前标记成replace，在同一个系统中replace并不会产生这个标记。 但是这样看上去会有歧义， 会理解成replace命令会标记成这样子。 需要换一个名字NonceConfilct？ReplaceByOther?
@hunjixin hunjixin added P2 Medium - we should get to this soon V-venus-messager venus-messager component C-enhancement Category: feature enhancement labels Dec 23, 2022
@Fatman13
Copy link
Contributor

可以从用户角度，如果需要用户操作或者需要用户执行什么，来命名？

@diwufeiwen diwufeiwen mentioned this issue Jan 3, 2023
Closed
54 tasks
@Fatman13
Copy link
Contributor

Fatman13 commented Jan 9, 2023 •
edited
Loading

NonceConflict +1

@hunjixin hunjixin mentioned this issue Jan 9, 2023
Merged
6 tasks
@hunjixin hunjixin self-assigned this Jan 9, 2023
@hunjixin hunjixin mentioned this issue Jan 9, 2023
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hunjixin hunjixin

Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon V-venus-messager venus-messager component
Projects
Venus Project
Archived in project
Milestone
Chain Service v1.10.0 / 链服务v1.10.0
2 participants
@Fatman13 @hunjixin