Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TB] Create the form template and organisms #731

Open
lwnoble opened this issue Nov 27, 2023 · 3 comments
Open

[TB] Create the form template and organisms #731

lwnoble opened this issue Nov 27, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request theme builder app Theme Builder application

Comments

@lwnoble
Copy link
Contributor

lwnoble commented Nov 27, 2023

We need to create a form component

  • Each form component will have an input type (text, dropdown, multi-select dropdown text area, or type ahead) * Note we do not yet have a type ahead input component
  • Each form component will have a fixed or floating label (We can start with just fixed)
  • The form element may have the following variables:
  • Help Text
  • A notification (Error, warning, success or info)

You can view the designs in Figma here:
https://www.figma.com/file/VV48uh4FjSEpCLqR5bwUPJ/Theme-Builder---MASTER?type=design&node-id=1161-112517&mode=design&t=HIdhAwflZ68rX4Dz-0

Look under components > form

Proposed Solution

@aaronreed708 aaronreed708 added enhancement New feature or request awaiting feedback Issue is blocked until awaiting feedback theme builder app Theme Builder application labels Nov 28, 2023
@aaronreed708
Copy link
Contributor

aaronreed708 commented Nov 28, 2023

@lwnoble not sure what you mean by component and I don't appear to have access to the Figma to know exactly what you are envisioning. Do you mean a new molecule that has some associated settings? Or is this a new organism that doesn't have settings?

This may be a good first issue once we have this clarification.

@aaronreed708 aaronreed708 changed the title [TB] Create the form component [TB] Create the form organism Nov 30, 2023
@aaronreed708
Copy link
Contributor

Epic to capture requirements, subsequent implementation issues to follow

@aaronreed708 aaronreed708 moved this to High Priority in ThemeBuilder Nov 30, 2023
@aaronreed708
Copy link
Contributor

aaronreed708 commented Jan 3, 2024

Discussed with @lwnoble today. We came to the conclusion that this collection of form items is a template, not a component or molecule.

where @lwnoble says, "form element", that would be one of the following molecules/components: text, dropdown, multi-select dropdown, text area, or type ahead. Where she mentions "form component" above, that will actually be a form organism.

So to summarize our discussions, this issue seeks to create a form template, as designed in the Figma link above, that will layout a bunch of form organisms that demonstrate many of the potential variations that a form organism may take based on their configurable variables.

Todo's:

  • create form components like label (fixed initially, then add floating), help, or notification (Error, warning, success or info)
    • some thought needs to be given here whether these would have value in the Theme Builder UI as it exists today. Would the end user want/need to configure labels, for example, system wide (which is what a design system would do)? Or would we just show them in the "Components" tab as something that the end user can use to build organisms, but not necessarily enforce system wide?
  • create form organisms that use the form elements like text, dropdown, multi-select dropdown, text area, or type ahead in combination with the molecules/components like label, help, or notification
    • a form organism page could have radio butons, switches, etc. where these controls affect what shows in the demonstration/display area of the organism.
      • perhaps a switch to turn off/hide and turn on/show the error/notification area, a switch to make the label fixed or float, etc.
  • create a form template that follows the Figma design and demonstrates the form organisms in a wide variety of configurations
  • a future/stretch goal would be to allow a designer to create a form template and dynamically add (using drag and drop?) form organisms to the form with user-provided configurations
    • the goal here would be to allow a designer to pass to a developer something that can be loaded into Theme Builder and, once loaded in Theme Builder, show their vision in a tangible, working environment.

I updated the title of this issue to reflect these clarifications.

@aaronreed708 aaronreed708 changed the title [TB] Create the form organism [TB] Create the form template and organisms Jan 4, 2024
@aaronreed708 aaronreed708 removed the awaiting feedback Issue is blocked until awaiting feedback label Jan 4, 2024
@evangk6 evangk6 self-assigned this Mar 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request theme builder app Theme Builder application
Projects
Status: High Priority
Development

No branches or pull requests

3 participants