Skip to content

Remove dev dependencies from dependencies list #1565

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
cabljac opened this issue May 31, 2023 · 1 comment · May be fixed by #2296
Open

Remove dev dependencies from dependencies list #1565

cabljac opened this issue May 31, 2023 · 1 comment · May be fixed by #2296
Labels
dependencies Pull requests that update a dependency file

Comments

@cabljac
Copy link
Contributor

cabljac commented May 31, 2023

Several extensions have things like jest and @types/... packages in their dependencies.

These should be moved to devDependencies.

In the past the reason for @types/... being in dependencies was because it needed to be for the build step of the extension. I'm not sure what the situation is now.

This should be checked across all 4 official repositories.

@dackers86
Copy link
Member

As the build processes uses docker, can we make sure this works as expected on install. Typically, in the past some dependencies will causes errors as the module cannot be found.

@dackers86 dackers86 added the dependencies Pull requests that update a dependency file label Jun 9, 2023
@CorieW CorieW linked a pull request Feb 19, 2025 that will close this issue
8 tasks
@CorieW CorieW self-assigned this Feb 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants