Skip to content

Commit 73357da

Browse files
authored
Remove default value for max_attempts argument to RunTransaction(). (#9952)
1 parent 0678d64 commit 73357da

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Firestore/core/src/api/firestore.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,10 @@ class Firestore : public std::enable_shared_from_this<Firestore> {
9393
WriteBatch GetBatch();
9494
core::Query GetCollectionGroup(std::string collection_id);
9595

96-
// TODO(dconeybe): Remove the default value of `max_attempts` once
97-
// the firebase-cpp-sdk has been updated to specify an explicit value.
96+
// The default value for `max_attempts` is `kDefaultTransactionMaxAttempts`.
9897
void RunTransaction(core::TransactionUpdateCallback update_callback,
9998
core::TransactionResultCallback result_callback,
100-
int max_attempts = kDefaultTransactionMaxAttempts);
99+
int max_attempts);
101100

102101
void Terminate(util::StatusCallback callback);
103102
void ClearPersistence(util::StatusCallback callback);

0 commit comments

Comments
 (0)