Skip to content

Commit 44f13b3

Browse files
committed
Remove safeAttrPrefix usage with src in auth
1 parent eed8523 commit 44f13b3

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

packages/auth/src/platform_browser/index.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
*/
1717

1818
import { FirebaseApp, getApp, _getProvider } from '@firebase/app';
19-
import { safeAttrPrefix } from 'safevalues';
20-
import { safeElement } from 'safevalues/dom';
2119

2220
import {
2321
initializeAuth,
@@ -126,7 +124,7 @@ _setExternalJSProvider({
126124
// TODO: consider adding timeout support & cancellation
127125
return new Promise((resolve, reject) => {
128126
const el = document.createElement('script');
129-
safeElement.setPrefixedAttribute([safeAttrPrefix`src`], el, 'src', url);
127+
el.setAttribute('src', url);
130128
el.onload = resolve;
131129
el.onerror = e => {
132130
const error = _createError(AuthErrorCode.INTERNAL_ERROR);

packages/auth/src/platform_browser/load_js.test.ts

+2-11
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
import { expect, use } from 'chai';
1919
import * as sinon from 'sinon';
2020
import sinonChai from 'sinon-chai';
21-
import { safeAttrPrefix } from 'safevalues';
22-
import { safeElement } from 'safevalues/dom';
2321

2422
import {
2523
_generateCallbackName,
@@ -46,12 +44,7 @@ describe('platform-browser/load_js', () => {
4644
loadJS(url: string): Promise<Event> {
4745
return new Promise((resolve, reject) => {
4846
const el = document.createElement('script');
49-
safeElement.setPrefixedAttribute(
50-
[safeAttrPrefix`src`],
51-
el,
52-
'src',
53-
url
54-
);
47+
el.setAttribute('src', url);
5548
el.onload = resolve;
5649
el.onerror = e => {
5750
const error = _createError(AuthErrorCode.INTERNAL_ERROR);
@@ -72,9 +65,7 @@ describe('platform-browser/load_js', () => {
7265

7366
// eslint-disable-next-line @typescript-eslint/no-floating-promises
7467
_loadJS('http://localhost/url');
75-
expect(safeElement.setPrefixedAttribute).to.have.been.calledWith(
76-
[safeAttrPrefix`src`],
77-
el,
68+
expect(el.setAttribute).to.have.been.calledWith(
7869
'src',
7970
'http://localhost/url'
8071
);

0 commit comments

Comments
 (0)