Skip to content

Commit 8e82fe9

Browse files
authored
Enable secret manager API during ext:update (#5703)
1 parent fd879c2 commit 8e82fe9

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
- firestore:locations
88
- Adds `extensions` as an option in `firebase init`.
99
- Relaxed repo URI validation in ext:dev:publish (#5698).
10-
- Added Secret Manager API enablement during ext:install for extensions that use secrets (#5702).
10+
- Enable Secret Manager API during ext:install/update for extensions that use secrets (#5702).

src/commands/ext-update.ts

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
} from "../extensions/extensionsHelper";
1717
import * as paramHelper from "../extensions/paramHelper";
1818
import { inferUpdateSource } from "../extensions/updateHelper";
19+
import * as secretsUtils from "../extensions/secretsUtils";
1920
import * as refs from "../extensions/refs";
2021
import { getProjectId } from "../projectUtils";
2122
import { confirm } from "../prompt";
@@ -114,6 +115,10 @@ export const command = new Command("ext:update <extensionInstanceId> [updateSour
114115
return;
115116
}
116117

118+
if (secretsUtils.usesSecrets(newExtensionVersion.spec)) {
119+
await secretsUtils.ensureSecretManagerApiEnabled(options);
120+
}
121+
117122
const oldParamValues = manifest.readInstanceParam({
118123
instanceId,
119124
projectDir: config.projectDir,

0 commit comments

Comments
 (0)