Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: BeforeValidException message for decode #526

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: BeforeValidException message for decode #526

merged 1 commit into from
Jul 14, 2023

Conversation

vishwarajanand
Copy link
Collaborator

@vishwarajanand vishwarajanand commented Jul 14, 2023 •
edited by bshaffer
Loading

Addresses #514

BEGIN_COMMIT_OVERRIDE
fix: different BeforeValidException messages for nbf and iat (#526)
END_COMMIT_OVERRIDE

@vishwarajanand
fix: BeforeValidException message for decode

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fda76e4
@vishwarajanand vishwarajanand marked this pull request as ready for review July 14, 2023 14:16
@bshaffer
Copy link
Collaborator

bshaffer commented Jul 14, 2023 •
edited
Loading

@vishwarajanand as there is no "bug" here, this should be considered a "chore" instead of a "fix"

Now I see that this is to differentiate between iat and nbf, not just to add a better exception message. My mistake, I agree now that it is a fix!

@bshaffer bshaffer changed the title fix: BeforeValidException message for decode chore: BeforeValidException message for decode Jul 14, 2023
@bshaffer bshaffer merged commit 0a53cf2 into main Jul 14, 2023
@bshaffer bshaffer deleted the differentiate-errors branch July 14, 2023 17:49
@bshaffer bshaffer changed the title chore: BeforeValidException message for decode fix: BeforeValidException message for decode Jul 14, 2023
@release-please release-please bot mentioned this pull request Jul 14, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bshaffer bshaffer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishwarajanand @bshaffer