Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: Unable to authenticate with github #29

Closed
LeKSuS-04 opened this issue Jul 31, 2023 · 3 comments
Closed

[bug]: Unable to authenticate with github #29

LeKSuS-04 opened this issue Jul 31, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@LeKSuS-04
Copy link

Describe the bug
I'm unable to # with github. When I'm trying to do so, I get a blank html page with error message: The username must not be containing any spaces

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://firecamp.dev/
  2. Press "# or # in Firecamp image
  3. Press "Continue with Github"
    image
  4. Try to # with my Github account (lol)

Expected behavior
I expected to be signed in

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Brave
  • Version 115

Additional context

@shreya-gr
Copy link
Collaborator

@LeKSuS-04 thank you for reporting the issue. I appreciate it. My team will start resolving this bug and update you on the progress.

@Nishchit14
Copy link
Contributor

The reason is that the username is containing the - Hyphen, dash special character. Currently, in Firecamp the username must not be containing any spaces or special characters. I am assuming the username is @LeKSuS-04

We need to rethink this case. cc @shreya-gr (your one is also having - 😄 )

@Nishchit14 Nishchit14 self-assigned this Jul 31, 2023
@Nishchit14 Nishchit14 added bug Something isn't working enhancement New feature or request labels Jul 31, 2023
@Nishchit14
Copy link
Contributor

This has been fixed in v3.2.1, Now we're allowing GitHub-style usernames in Firecamp. Thank you for reporting it @LeKSuS-04

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants