-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support cross-origin stylesheets when CORS enabled #248
Comments
I personally like option 3 as well. My only real concern is the potential for it to blow up alerting systems that might be listening to fetch failures globally and reporting on them. That's probably a reasonable thing, but it might also lead to a bit of unexpected perf hits. For example all of the google fonts come via external stylesheets and would all be parsed in this manner, as well as any other externally injected stylesheets from ad servers and such. Not saying I'm advocating for option 1, but it has some additional advantages:
The build preference for it could also be one that uses those options, but it doesn't seem as appealing to me. Feels like either get all the good stuff out of the box on import or you want to take a more manual approach. |
An allow-list defaulting to |
In #78, @calinoracation mentioned that there are cases where external stylesheets are used from CORS-enabled origins, where it would also be nice to support scroll driven animations.
We could one of the following:
I think I'm leaning towards option 3 as it seems simplest.
The text was updated successfully, but these errors were encountered: