Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Game render box cleanup #1691

Merged
merged 4 commits into from
Nov 27, 2022
Merged

refactor: Game render box cleanup #1691

merged 4 commits into from
Nov 27, 2022

Conversation

renancaraujo
Copy link
Member

@renancaraujo renancaraujo commented Jun 2, 2022 •
edited
Loading

Description

Cleanup on the relationship between he game render box and the game instance.

  • The render objects receive new build contexts on rebuild (possible bug fix).
  • Game is attached if it is added to the render object even after the render object creation (possible bug fix).
  • When loading, GameWidget now builds a SizedBox.shirink() when there is no loader specified.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

spydon
spydon approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm so far!

@renancaraujo renancaraujo force-pushed the renan/fix-render-box-lifecycle branch 3 times, most recently from 1289830 to 9b4c4f2 Compare June 5, 2022 10:34
alestiago
alestiago reviewed Jun 14, 2022
View reviewed changes
packages/flame/lib/src/game/game_render_box.dart Outdated
attachGame(owner);
}

void attachGame(PipelineOwner owner) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do attachGame and detachGame need to be public? Can they be private?

@renancaraujo renancaraujo force-pushed the renan/fix-render-box-lifecycle branch from 9b4c4f2 to ed67a44 Compare July 11, 2022 14:23
@renancaraujo renancaraujo force-pushed the renan/fix-render-box-lifecycle branch from ed67a44 to ef92751 Compare November 26, 2022 12:56
@renancaraujo renancaraujo force-pushed the renan/fix-render-box-lifecycle branch from ef92751 to 78a521c Compare November 26, 2022 13:11
@renancaraujo renancaraujo marked this pull request as ready for review November 26, 2022 13:11
@spydon spydon changed the title refactor: game render box cleanup refactor: Game render box cleanup Nov 27, 2022
@spydon spydon merged commit 60a5830 into main Nov 27, 2022
@spydon spydon deleted the renan/fix-render-box-lifecycle branch November 27, 2022 16:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@st-pasha st-pasha st-pasha left review comments

@alestiago alestiago alestiago left review comments

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@luanpotter luanpotter Awaiting requested review from luanpotter

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renancaraujo @spydon @erickzanardo @st-pasha @alestiago