Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Use new "super"-constructors in ShapeComponents #1752

Merged
merged 6 commits into from
Jun 24, 2022
Merged

refactor: Use new "super"-constructors in ShapeComponents #1752

merged 6 commits into from
Jun 24, 2022

Conversation

st-pasha
Copy link
Contributor

Description

This is a minor refactor to make the constructors look simpler.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

spydon
spydon approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had a linting rule for this 🤔

@spydon spydon merged commit b69e8d8 into flame-engine:main Jun 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st-pasha @spydon