Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Expose hitboxParent from Hitbox #1928

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix: Expose hitboxParent from Hitbox #1928

merged 1 commit into from
Sep 20, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 20, 2022 •
edited
Loading

Description

Since the hitboxParent will be needed from outside of the hitbox, protected is removed and turned into a getter instead.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Related to #1894

@spydon spydon mentioned this pull request Sep 20, 2022
Merged
7 tasks
@spydon spydon requested a review from a team September 20, 2022 21:18
@spydon spydon enabled auto-merge (squash) September 20, 2022 21:18
erickzanardo
erickzanardo approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests that could be added to prevent this to happen again?

@spydon spydon merged commit 3ba9335 into main Sep 20, 2022
@spydon spydon deleted the spydon/expose-hitbox-parent branch September 20, 2022 21:25
@spydon
Copy link
Member Author

spydon commented Sep 20, 2022

Any tests that could be added to prevent this to happen again?

This wasn't a bug, there just wasn't any need for this field to be exposed before.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @erickzanardo