Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add autoResize for SpriteAnimationComponent and SpriteAnimationGroupComponent #2453

Merged
merged 9 commits into from
Apr 1, 2023

Conversation

ufrshubham
Copy link
Member

@ufrshubham ufrshubham commented Mar 31, 2023

Description

This PR extends autoResize to SpriteAnimationComponent and SpriteAnimationGroupComponent similar to what was done in #2430 and #2442.

Additionally, this PR also adds playing property to SpriteAnimationGroupComponent. If it is desired to make this appear as a separate entry in the changlog, I can move this change to a separate PR as it is completely unrelated to the auto-resize changes.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

NA

@ufrshubham ufrshubham marked this pull request as ready for review March 31, 2023 19:42
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some minor comments

@spydon spydon merged commit dbeba23 into main Apr 1, 2023
@spydon spydon deleted the devkage/auto-resize-sprite-based-components branch April 1, 2023 09:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants