-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: ComponentKey API #2566
feat: ComponentKey API #2566
Conversation
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, maybe just add a specific example for the keys?
I considered that, but I felt that this example wouldn't show anything much visual, so I went with changing an existent example to make use of the new API. Do you feel we needed to have a dedicated example only for the key api? and if so, any idea how that example would look like? |
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
It would be hard for a user to find out that the key api example is on the keyboard example. |
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@spydon added a more specific example, let me know what you think Screen.Recording.2023-06-20.at.08.57.00.mov |
Cute! Love it, and it should be clear what is happening too 😊 |
Description
This PR adds a new key api on FCS, which will allow users to get a component from the tree, without needing to iterate over all the children or a parent descendants.
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues