Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Set SpriteButtonComponent sprites in onMount #3327

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: Set SpriteButtonComponent sprites in onMount #3327

merged 3 commits into from
Oct 3, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Oct 3, 2024

Description

Since it will be confusing for the user to have to call super.onLoad last when they override onLoad, we move setting the sprites to onMount.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon mentioned this pull request Oct 3, 2024
Merged
6 tasks
@spydon
Copy link
Member Author

spydon commented Oct 3, 2024

@puneet-739 now it should be fixed, I didn't have the time to properly test it last time since I wasn't home, but now I was.
If you want to test it you can depend on this branch in your project, or main once it is merged.

@spydon spydon merged commit f36533e into main Oct 3, 2024
8 checks passed
@spydon spydon deleted the docs/explain-button-sprite branch October 3, 2024 20:06
@puneet-739
Copy link
Contributor

puneet-739 commented Oct 4, 2024 •
edited
Loading

@puneet-739 now it should be fixed, I didn't have the time to properly test it last time since I wasn't home, but now I was. If you want to test it you can depend on this branch in your project, or main once it is merged.

@spydon everything is working perfectly now! : )

luanpotter pushed a commit that referenced this pull request Oct 15, 2024
@spydon @luanpotter
fix: Set SpriteButtonComponent sprites in onMount (#3327)
616ec82 
Since it will be confusing for the user to have to call `super.onLoad`
last when they override `onLoad`, we move setting the `sprites` to
`onMount`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spydon @puneet-739 @erickzanardo