-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: Test case for extended SpriteButtonComponent
#3318
test: Test case for extended SpriteButtonComponent
#3318
Conversation
…/puneet-739/flame into test-case-for-CustomSpriteButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests for the SpriteButtonComponent
should live in the sprite_button_component_test.dart
file.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are just copies of already existing tests, but going through an extended version that isn't exposed to the user. I don't think we want this type of testing pattern in the code-base.
If you disagree with a good argument I can open it again, but I'll close it for now.
Oh, ok. |
@puneet-739 you're right, can you try #3327? It should solve the issue so that the user doesn't have to call |
@puneet-739 I changed my mind, due to the intricacies of the |
SpriteButtonComponent
packages/flame/test/components/input/sprite_button_component_test.dart
Outdated
Show resolved
Hide resolved
Added an extra test case for testing `SpriteButtonComponent` class. which includes a `CustomSpriteButtonComponet` class to test the working with `onLoad` instead of directly using Constructor. --------- Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com> Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Description
Added an extra test case for testing
SpriteButtonComponent
class.which includes a
CustomSpriteButtonComponet
class to test the working withonLoad
instead of directly using Constructor.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
It may help working on the issues like #3293