Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add team filter in topology query #184

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adityathebe
Copy link
Member

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

E2E -

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 08e668c.

♻️ This comment has been updated with latest results.

@moshloop
Copy link
Member

@adityathebe can we add a test for this ?

@adityathebe adityathebe force-pushed the feat/topology-teams-filter branch from 7f008c2 to 9080183 Compare July 3, 2023 05:32
@adityathebe adityathebe force-pushed the feat/topology-teams-filter branch from 9080183 to edf33f2 Compare July 3, 2023 06:05
@adityathebe adityathebe force-pushed the feat/topology-teams-filter branch from edf33f2 to 08e668c Compare July 3, 2023 09:02
@@ -44,6 +45,7 @@ func testTopologyJSON(opts TopologyOptions, path string) {
}

var _ = ginkgo.Describe("Topology behavior", func() {
format.MaxLength = 0 // So the diff is not truncated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@moshloop moshloop marked this pull request as draft March 17, 2024 09:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Topology] Filtering by Team makes no difference
3 participants