Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RFC]: Bring Flask-GoogleMaps up to date with latest dependencies #158

Open
argysamo opened this issue Mar 26, 2024 · 1 comment · May be fixed by #159
Open

[RFC]: Bring Flask-GoogleMaps up to date with latest dependencies #158

argysamo opened this issue Mar 26, 2024 · 1 comment · May be fixed by #159

Comments

@argysamo
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Flask-GoogleMaps is not compatible with latest Flask 3.0.0 version. As described in [bug] import "Markup" fails when using Flask 3.0+ in __init__.py #157 Markup is not bundled with Flask anymore, and needs to be imported from elsewhere
  • Latest Google maps API deprecated Marker and promotes AdvancedMarker instead. AdvancedMarker is much more powerful, as you can use ones with different colours in a very straightforward manner.

Describe the solution you'd like

  • Update Flask-GoogleMaps so as to be compatible with latest Flask.
  • Remove obsolete (Google Maps) Markers and use AdvancedMarkers instead.

Describe alternatives you've considered

NA

Additional context
NA
@argysamo
Copy link
Collaborator Author

I have started working on the proposed changes and will submit a PR soon.

@argysamo argysamo linked a pull request Apr 14, 2024 that will close this issue
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: [RFC]: Bring Flask-GoogleMaps up to date with latest dependencies argysamo/Flask-GoogleMaps
1 participant
@argysamo