Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dead links to grub patches in documentation #1638

Closed
elelay opened this issue Feb 9, 2025 · 4 comments · Fixed by flatcar/flatcar-website#386
Closed

dead links to grub patches in documentation #1638

elelay opened this issue Feb 9, 2025 · 4 comments · Fixed by flatcar/flatcar-website#386
Labels
good first issue Get started with Flatcar contribution with this issue. kind/docs

Comments

@elelay
Copy link

elelay commented Feb 9, 2025

There are two dea links on https://www.flatcar.org/docs/latest/reference/developer-guides/sdk-disk-partitions/:

I couldn't find the new location or I would have submitted a patch.

@tormath1
Copy link
Contributor

Hi @elelay and thanks for the report! Those patches are now located here: https://github.com/flatcar/scripts/tree/main/sdk_container/src/third_party/coreos-overlay/coreos/user-patches/sys-boot/grub

This helps to keep our grub version more close from the upstream. Would you still be interested to send a patch?

Flatcar's documentation is hosted on flatcar/flatcar-website repo.

@tormath1 tormath1 added the good first issue Get started with Flatcar contribution with this issue. label Feb 10, 2025
@elelay
Copy link
Author

elelay commented Feb 11, 2025

Hi Mathieu,
thanks for the links. Here is the PR :-)

@tormath1
Copy link
Contributor

Hi @elelay, your contribution has been merged and it is now live. Thanks for helping keeping this fresh and up-to-date 🚀

@elelay
Copy link
Author

elelay commented Feb 11, 2025

Thank you for the quick merge!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Get started with Flatcar contribution with this issue. kind/docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants