Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sys-kernel/coreos-modules: Enable CONFIG_FTRACE_SYSCALLS #2600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arilou
Copy link

@arilou arilou commented Jan 22, 2025

This config enables the syscall tracepoints which are mainly used by different security and observability tools.

Related to: flatcar/Flatcar#1617

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As this configuration has moved into the commonconfig file, we can remove it from the the amd64 config file as well:

A changelog entry will be needed similar to this PR: #2484

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I kicked-off a CI build. Changelog entry is still missing but it does not impact the CI run.

@arilou arilou force-pushed the arm64_enable_syscalls_tps branch from 5bfe588 to e9ddcf4 Compare January 22, 2025 08:36
This config enables the syscall tracepoints which are mainly used by
different security and observability tools.

The config was moved to common, so it's removed from the AMD64 only
config.

Signed-off-by: Jon Doron <jond@wiz.io>
@arilou arilou force-pushed the arm64_enable_syscalls_tps branch from e9ddcf4 to 341f1e1 Compare January 22, 2025 08:54
@arilou
Copy link
Author

arilou commented Jan 22, 2025

Thanks! Done

@arilou arilou deployed to development January 22, 2025 09:04 — with GitHub Actions Active
@tormath1
Copy link
Contributor

@arilou image is available for download here: https://github.com/flatcar/scripts/actions/runs/12904571853/artifacts/2467235852 - can you give a try to see if it works as expected?

Failures in the CI are not related to this change (it happens when the test run from a fork).

Copy link

github-actions bot commented Jan 22, 2025

@tormath1
Copy link
Contributor

@arilou image is available for download here: https://github.com/flatcar/scripts/actions/runs/12904571853/artifacts/2467235852 - can you give a try to see if it works as expected?

Failures in the CI are not related to this change (it happens when the test run from a fork).

LGTM but I will let you confirm:

core@localhost ~ $ zcat /proc/config.gz | grep CONFIG_FTRACE_SYSCALLS
CONFIG_FTRACE_SYSCALLS=y
core@localhost ~ $ uname -a
Linux localhost 6.6.71-flatcar #1 SMP PREEMPT Wed Jan 22 10:11:29 -00 2025 aarch64 GNU/Linux
core@localhost ~ $ sudo ls -l /sys/kernel/tracing/events/syscalls/ | head
total 0
-rw-r-----. 1 root root 0 Jan 22 13:28 enable
-rw-r-----. 1 root root 0 Jan 22 13:28 filter
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_accept
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_accept4
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_acct
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_add_key
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_adjtimex
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_arm64_personality
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_bind

@arilou
Copy link
Author

arilou commented Jan 22, 2025

Looks good! Thanks you

@tormath1
Copy link
Contributor

(FYI, I'm holding this PR until the current release is done to avoid any confusion)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Testing / in Review
Development

Successfully merging this pull request may close these issues.

2 participants