Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handle HTTP redirect status code #27

Closed
dongsupark opened this issue Nov 14, 2023 · 1 comment · Fixed by #29
Closed

Handle HTTP redirect status code #27

dongsupark opened this issue Nov 14, 2023 · 1 comment · Fixed by #29
Assignees
@dongsupark
Labels
kind/feature A feature request.

Comments

@dongsupark
Copy link
Member

In download_and_hash of src/download.rs, we should also either make use of https://docs.rs/reqwest/latest/reqwest/redirect/struct.Attempt.html#method.follow or check is_redirection and act accordingly.
@dongsupark dongsupark added the kind/feature A feature request. label Nov 14, 2023
This was referenced Nov 14, 2023
Merged
Merged
@dongsupark
Copy link
Member Author

PR #29.
It is basically the 1st approach, reqwest Attempt. The default reqwest Client builder already supports the redirect attempt.

Went with the 2nd approach as well, but it was a big ugly rabbit hole.

@github-actions github-actions bot mentioned this issue Nov 22, 2023
Closed
@dongsupark dongsupark self-assigned this Nov 27, 2023
@github-actions github-actions bot mentioned this issue Dec 22, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dongsupark dongsupark

Labels
kind/feature A feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle HTTP redirects using reqwest Client builder flatcar/ue-rs
1 participant
@dongsupark