Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use internal function inside and inside_meshgrid' methods #2207

Open
marc-flex opened this issue Jan 28, 2025 · 0 comments
Open

Use internal function inside and inside_meshgrid' methods #2207

marc-flex opened this issue Jan 28, 2025 · 0 comments

Comments

@marc-flex
Copy link
Contributor

          So every geometry (so including `Box`) has an [inside](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L89) and [inside_meshgrid](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L179) method. Can these be used directly instead of this? It seems like this handles some special cases but wondering if you've considered those.

Originally posted by @momchil-flex in #2205 (comment)

@marc-flex marc-flex self-assigned this Jan 28, 2025
@marc-flex marc-flex changed the title So every geometry (so including Box) has an [inside](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L89) and [inside_meshgrid](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L179) method. Can these be used directly instead of this? It seems like this handles some special cases but wondering if you've considered those. Use internal function inside and `inside_meshgrid'' methods Jan 28, 2025
@marc-flex marc-flex changed the title Use internal function inside and `inside_meshgrid'' methods Use internal function inside and inside_meshgrid' methods Jan 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant