Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: Scaling coefficient is None if not passed in config. #23

Open
bergr7 opened this issue Apr 29, 2024 · 0 comments
Open

Bug: Scaling coefficient is None if not passed in config. #23

bergr7 opened this issue Apr 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bergr7
Copy link
Collaborator

bergr7 commented Apr 29, 2024

🐛 Bug report

Summary

The scaling coefficient is None if not passed in the config file.

Actual Behavior

The scaling coefficient takes None if it's not passed in the config file, resulting in a merge error.

Expected behavior

The scaling coefficient should use the default value if it's not passed in the config file.

To Reproduce

Merge configuration file (if relevant):

method: dare-ties-merging
method_global_parameters:
  p: 0.3
base_model: mistralai/Mistral-7B-v0.1
models:
  - model: mistralai/Mistral-7B-v0.1
  - model: mistralai/Mistral-7B-Instruct-v0.1
    weight: 0.5
  - model: BioMistral/BioMistral-Safetensors
    weight: 0.5
directory_settings:
  output_dir: ./biomistral/biomistral_dare_ties_7b/
hf_token:
  token: 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
  trust_remote_code: True
device: cuda

Environment

  • OS: Ubuntu 22.04.4 LTS
  • Python version:Python 3.10.13
  • Library version: 0.1.0
  • Other relevant dependencies: NA
@bergr7 bergr7 added the bug Something isn't working label Apr 29, 2024
@bergr7 bergr7 moved this to Backlog in Work In Progress May 1, 2024
@bergr7 bergr7 moved this from Backlog to Ready in Work In Progress May 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

1 participant